Skip to content

Fix 1413 - Remove readonly from radio and checkboxes. Use aria-readonly instead. #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 23, 2020
Merged

Fix 1413 - Remove readonly from radio and checkboxes. Use aria-readonly instead. #1414

merged 5 commits into from
Dec 23, 2020

Conversation

intergalacticspacehighway
Copy link
Contributor

@intergalacticspacehighway intergalacticspacehighway commented Dec 21, 2020 •
edited
Loading

Closes #1413

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  • The below matching files needed changes.
  • Run
yarn test checkbox
yarn test radio
yarn test Provider

🧢 Your Project:

devongovett
devongovett reviewed Dec 22, 2020
View reviewed changes
packages/@react-aria/radio/src/useRadio.ts Outdated
tabIndex,
disabled: isDisabled,
readOnly: isReadOnly,
'aria-readonly': isReadOnly,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to do something like this since false is the default:

Suggested change
'aria-readonly': isReadOnly,
'aria-readonly': isReadOnly || undefined,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Fixed

@devongovett devongovett merged commit d200ad5 into adobe:main Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

@dannify dannify Awaiting requested review from dannify

@snowystinger snowystinger Awaiting requested review from snowystinger

@majornista majornista Awaiting requested review from majornista

@jnurthen jnurthen Awaiting requested review from jnurthen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove readonly attribute from checkboxes, switches, and radios
2 participants
@intergalacticspacehighway @devongovett